-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: ndimage.value_indices: deal with unfixed types #20644
Conversation
ah right, I'll need preprocessor guards or something similar, that's fun |
266330b
to
40fc88b
Compare
That's a little closer, but 32-bit Linux failure is real. I could probably skip that case and argue we're still doing better than |
* Fixes scipygh-19423 * Add a few more `case` statements to account for the (i.e., Windows) data types that don't have a fixed width, and add a regression test. [skip circle] [skip cirrus]
40fc88b
to
e1a4c36
Compare
Alright, this seems to be portable now, and CI is passing. There may be a more elegant solution, though the patch isn't too big anyway. |
Thanks @tylerjereddy I wrote the original switch statements, and had no idea that these generic names had such different behaviour on Windows. Thanks for rescuing that, much appreciated. :-) |
@grlee77 are you happy for this to be merged? I don't usually add shims to |
I'm going to take the approval of the original author of the code as a substitute/"next best thing" for core dev approval and self-merge this ahead of the |
Fixes BUG:
scipy.ndimage.value_indices
returns empty dict forintc
/uintc
dtype on Windows #19423Add a few more
case
statements to account for the (i.e., Windows) data types that don't have a fixed width, and add a regression test.[skip circle] [skip cirrus]