ENH: stats.describe: add array API support #20667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdhaber
added
scipy.stats
enhancement
74 tasks
|
CI failure appears to be unrelated. |
j-bowhay
reviewed
May 8, 2024
|
Thanks @mdhaber planning to review this and other from Wednesday onwards |
j-bowhay
reviewed
May 14, 2024
j-bowhay
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issue
Towards #20544
What does this implement/fix?
Adds array API support to
scipy.stats.describe.Additional information
I think our policy of translating existing tests rather than rewriting is good, but it was pretty cumbersome for this one. Most of what we really need is one big property-based test showing that the results of
describematch the results of the functions it calls. Those functions are tested elsewhere.