-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: stats.gstd: return result rather than raising #20696
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, a quick comment and a question as review comments, those shouldn't block anything.
I'll make a post to the mailing list today.
@mdhaber We've had two approvals on the mailing list and the failures on the CI are unrelated. Would you like to add anything before I give it a final review? |
Besides the suggestions, nope. Feel free to commit those before merge. |
Co-authored-by: Matt Haberland <mhaberla@calpoly.edu>
Co-authored-by: Matt Haberland <mhaberla@calpoly.edu>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes lgtm, I've merged in your changes. If they pass the test suite, I'll merge this today / tomorrow.
Looks like CI is happy. I took the liberty of assuming this would make it and adding a release note. |
Merged, thanks for your work @mdhaber! |
Reference issue
gh-20285
What does this implement/fix?
gh-20285 noted changes to
stats.gstd
that would make it more amenable to the addition of array API support. This implements those changes. It also deprecates support for masked arrays, sincegstd
seems to be unique amongstats
functions in that it advertises support for masked arrays such that it returns a masked array with no masked elements (many handle them, but other functions return regular arrays).Additional information
See #20285 (comment) for context and additional rationale.