MAINT: numpy cleanup version bumps: fixes issue #20458 #20711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The minimum numpy version in `scipy/scipy/__init__.py` has been aligned to the minimum requirement of `pyproject.toml`. A numpy version check has been removed from test `test_moments` in `scipy/stats/tests/test_multivariate.py` because the check looked for a numpy version earlier than the minimum. This pull request does not fully solve scipy#20458. I will come back at it after discussion.
github-actions
bot
added
scipy.stats
maintenance
There was a problem hiding this comment.
This PR is basically a duplicate of #20459 with an additional problem at the moment.
Also, the point in question, the pytest version guard, was already discussed over there at: #20459 (review)
After checking discussion to PR scipy#20459, found that the pytest guards could be removed. So I did, and removed a couple imports and a function which would became unused too. Also, this commit fixes an horrible error with the previous one, which would ban import prior to NumPy 2.0.0. (sorry! and thanks @tylerjereddy) To fix this I change the numpy minimum version of `scipy/__init__.py` to `1.23.5` as user JacobOgle did with PR scipy#20459. Thanks Jacob!
peppedilillo
changed the title
|
The CI failures were unrelated, and the diff seems "ok" now, so I've squash-merged it. Note that I've added @JacobOgle as a co-author given the two active PRs. |
Thank you. Great to have added @JacobOgle: i copypasted his numpy version! Thank you too Jakob! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum numpy version in
scipy/scipy/__init__.pyhas been aligned to the minimum requirement ofpyproject.toml. A numpy version check has been removed from testtest_momentsinscipy/stats/tests/test_multivariate.pybecause the check looked for a numpy version earlier than the minimum. This pull request does not fully solve #20458. I will come back at it after discussion.Reference issue
Partially solves issue #20458
What does this implement/fix?
This aligns a few numpy versions. Does not align the pytest version.
Additional information
I'm open to working on fixing the pytest versions too, as reported in #20458. However, it is not clear to me what is the exact pytest version we should report. Shall we find it ourselves or you already know? Tried grepping for it but didn't find anything useful.