Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken mercurial http post args configuration #1532

Merged
merged 1 commit into from
Feb 9, 2021

Conversation

sdorra
Copy link
Member

@sdorra sdorra commented Feb 8, 2021

Proposed changes

Fixes a regression which was introduced with #1416. In #1416 we have reimplemented the way configuration is passed to the mercurial cgi handler. Before #1416 we used environment variables which are picked up by hgweb.py, after #1416 we pass mercurial configurations as command line parameters directly in the HgCGIServlet. But sadly the configuration option for httppostargs uses still an environment variable, which is not picked up by anyone.

See #1525

Your checklist for this pull request

  • PR is well described and the description can be used as commit message on squash
  • Related issues linked to PR if existing and labels set
  • Target branch is not master (in most cases develop should bet the target of choice)
  • Code does not conflict with target branch
  • New code is covered with unit tests
  • Changelog entry file created in gradle/changelog
  • Definition of Done's fulfilled: DoD // UI DoD
  • Documentation updated (only necessary for new features or changed behaviour)

Checklist for branch merge request (not required for forks)

@sdorra sdorra added bug Something isn't working regression Mark an issue as a regression labels Feb 8, 2021
@eheimbuch eheimbuch self-assigned this Feb 9, 2021
@eheimbuch eheimbuch merged commit 7c50fd9 into develop Feb 9, 2021
@eheimbuch eheimbuch deleted the bugfix/hg_httppostargs branch February 9, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working regression Mark an issue as a regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants