Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating React Version in package.json #273

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Bhavesh588
Copy link

The npm show error of React version should be less then 16.x so I updated to current new version 17.0.2

@Bhavesh588 Bhavesh588 changed the title Update package.json Updating React Version in package.json Feb 7, 2022
@fongandrew
Copy link
Collaborator

Sorry for the delay in responding to this. If you're still interested in bumping the version, give it a go but check in the updated package-lock.json file as well.

@Bhavesh588
Copy link
Author

So do you want me to update the package-lock.json file? and then make the pull request?

@fongandrew
Copy link
Collaborator

Yes, whenever bumping package.json, you should also update package-lock.json if there's checked in. You can bump React to the latest v18 if you want too.

@fongandrew
Copy link
Collaborator

Oh wait -- actually, you might have to hold on that. This package uses Enzyme for testing and there's no official Enzyme adapter for React beyond v16. We'd need to migate the tests away from Enzyme to something else for this to work unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants