Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and fix failing tests, identify Mocha globals, and cleanup readme #68

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Alhadis
Copy link
Collaborator

@Alhadis Alhadis commented Sep 22, 2021

This PR is a combination of commits I prepared locally before an attempt to push revealed master is a protected branch. 馃槗 The changes are atomic and (hopefully) self-explanatory, but in short, they

  1. Update the versions of Node and Mocha used to run the tests
  2. Fix the currently-broken status badges in the readme
  3. Identify Mocha's globals to js2-mode so functions like describe() and it() aren't flagged as errors
  4. Improve the makefile's overall user-friendliness by:
    1. Only installing project dependencies when they don't exist
    2. Not assuming that an $NPM variable set in one's environment points to the npm(1) binary; I have $NPM set to /usr/local/lib/node_modules, so running make quickly failed.

      Note that it's still possible to override variables on a case-by-case basis like this:
      $ make NPM=/path/to/npm CASK=/path/to/cask install

I'll endeavour to keep future maintenance a little more review-friendly. 馃槈

/cc @scottaj

@Alhadis
Copy link
Collaborator Author

Alhadis commented Oct 6, 2021

Nudging @scottaj for an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant