Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse some abbreviated strings as relative dates #1219

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

Dunedan
Copy link
Contributor

@Dunedan Dunedan commented Feb 15, 2024

dateparser so far did consider strings like "1h20m" as an absolute time. This commit changes that, so "1h20" remains an absolute time, while "1h20m" is now considered a relative date. This makes the output much more predictable and not dependent on the use of whitespaces anymore.

Fixes #1012

Behavior before the changes:

>>> from datetime import datetime
>>> import dateparser
>>> ref_date = datetime(2023, 1, 2, 3, 4, 5)
>>> dateparser.parse("1h20", settings={"RELATIVE_BASE": ref_date})
datetime.datetime(2023, 1, 2, 1, 20)
>>> dateparser.parse("1h20m", settings={"RELATIVE_BASE": ref_date})
datetime.datetime(2023, 1, 2, 1, 20)
>>> dateparser.parse("1h 20m", settings={"RELATIVE_BASE": ref_date})
datetime.datetime(2023, 1, 2, 1, 44, 5)
>>> dateparser.parse("1h20m", settings={"RELATIVE_BASE": ref_date,
                                        "PREFER_DATES_FROM": "future"})
datetime.datetime(2023, 1, 3, 1, 20)

Behavior after the changes:

>>> from datetime import datetime
>>> import dateparser
>>> ref_date = datetime(2023, 1, 2, 3, 4, 5)
>>> dateparser.parse("1h20", settings={"RELATIVE_BASE": ref_date})
datetime.datetime(2023, 1, 2, 1, 20)
>>> dateparser.parse("1h20m", settings={"RELATIVE_BASE": ref_date})
datetime.datetime(2023, 1, 2, 1, 44, 5)
>>> dateparser.parse("1h 20m", settings={"RELATIVE_BASE": ref_date})
datetime.datetime(2023, 1, 2, 1, 44, 5)
>>> dateparser.parse("1h20m", settings={"RELATIVE_BASE": ref_date,
                                        "PREFER_DATES_FROM": "future"})
datetime.datetime(2023, 1, 2, 4, 24, 5)

dateparser so far did consider strings like "1h20m" as an absolute time.
This commit changes that, so "1h20" remains an absolute time, while
"1h20m" is now considered a relative date. This makes the output much
more predictable and not dependent on the use of whitespaces anymore.

Fixes scrapinghub#1012

Behavior before the changes:

```python
>>> from datetime import datetime
>>> import dateparser
>>> ref_date = datetime(2023, 1, 2, 3, 4, 5)
>>> dateparser.parse("1h20", settings={"RELATIVE_BASE": ref_date})
datetime.datetime(2023, 1, 2, 1, 20)
>>> dateparser.parse("1h20m", settings={"RELATIVE_BASE": ref_date})
datetime.datetime(2023, 1, 2, 1, 20)
>>> dateparser.parse("1h 20m", settings={"RELATIVE_BASE": ref_date})
datetime.datetime(2023, 1, 2, 1, 44, 5)
>>> dateparser.parse("1h20m", settings={"RELATIVE_BASE": ref_date,
                                        "PREFER_DATES_FROM": "future"})
datetime.datetime(2023, 1, 3, 1, 20)
```

Behavior after the changes:

```python
>>> from datetime import datetime
>>> import dateparser
>>> ref_date = datetime(2023, 1, 2, 3, 4, 5)
>>> dateparser.parse("1h20", settings={"RELATIVE_BASE": ref_date})
datetime.datetime(2023, 1, 2, 1, 20)
>>> dateparser.parse("1h20m", settings={"RELATIVE_BASE": ref_date})
datetime.datetime(2023, 1, 2, 1, 44, 5)
>>> dateparser.parse("1h 20m", settings={"RELATIVE_BASE": ref_date})
datetime.datetime(2023, 1, 2, 1, 44, 5)
>>> dateparser.parse("1h20m", settings={"RELATIVE_BASE": ref_date,
                                        "PREFER_DATES_FROM": "future"})
datetime.datetime(2023, 1, 2, 4, 24, 5)
```
@Gallaecio Gallaecio merged commit 29b1f94 into scrapinghub:master Feb 16, 2024
13 checks passed
@Gallaecio
Copy link
Member

Thanks!

@Dunedan Dunedan deleted the fix-relative-dates branch February 16, 2024 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Formats like "1h20m" should be treated as relative but are actually absolute
2 participants