Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect sound name #9550

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

bruh-9000
Copy link

@bruh-9000 bruh-9000 commented Apr 9, 2024

Resolves

Proposed Changes

Fixes incorrect sound name to the correct sound name

Reason for Changes

The sound name should be correct

Test Coverage

Please show how you have added tests to cover your changes

Browser Coverage

Check the OS/browser combinations tested (At least 2)

Mac

  • Chrome
  • Firefox
  • Safari

Windows

  • Chrome
  • Firefox
  • Edge

Chromebook

  • Chrome

iPad

  • Safari

Android Tablet

  • Chrome

@mxmou
Copy link
Contributor

mxmou commented Apr 10, 2024

The library JSON files are generated using a script. They aren't meant to be edited directly.

@bruh-9000
Copy link
Author

bruh-9000 commented Apr 10, 2024

What file are they developed in, and how would I do it the correct way? This is my first commit for scratch so I'm not very familiar with how it works.

@mxmou
Copy link
Contributor

mxmou commented Apr 11, 2024

I think only the ST can do it the correct way - the code that generates these files is private.

@bruh-9000
Copy link
Author

Hm okay, but I tested my way and it worked fine, so wouldn't it be fine anyways?

@mxmou
Copy link
Contributor

mxmou commented Apr 11, 2024

That's the ST's decision, but I imagine they would want to keep the project they use to generate the libraries in sync with the actual library data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shark 2 sprite has two sounds with the same name
2 participants