Reshape curves #1142
Merged
Reshape curves #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adroitwhiz
reviewed
Jul 28, 2020
adroitwhiz
previously approved these changes
Jul 28, 2020
Update comment to remove stroke Co-authored-by: adroitwhiz <adroitwhiz@protonmail.com>
adroitwhiz
approved these changes
Jul 28, 2020
|
The lint issue might be jsx-eslint/eslint-plugin-react#2728 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
Resolves #1143
Proposed Changes
Before
After
Reshaping only occurs if you click near the outline of the shape, not anywhere within the stroke
Reason for Changes
A reshape point appearing far away from where the user clicks is unexpected
Test Coverage
Tested manually