-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for OpenID connect providers #646
base: master
Are you sure you want to change the base?
Conversation
- allow OpenID connect to be used as generic authentication mechanism; - allow OpenID configuration to be obtained from an external source to get a generic API.
- expanded the constants used in the OpenID connect discovery specification.
- made the configuration a simple POJO that should be filled by the user before creating the OpenIdConnectApi.
Oh.. Interesting... OpenId isnot the goal for ScribeJava, but in case it won't make using ScribeJava more difficult... Thanks for PR. Will think on it |
The reason I've done this is that OpenID connect bolts on top of OAuth2 and well supported by ScribeJava. It saves me from writing lots of boilerplate code with the APIs provided by ScribeJava ;) |
nice to hear, that ScribeJava helps ;-) |
I would love something like this to be merged into here, OIDC is well established by now and of great use. |
You're definitely right! I have some plans, but a lack of time is my enemy. |
I've added some basic support for working with OpenID connect providers, such as Google and Microsoft. In contrast to the existing APIs, I've chosen to make this API a little more flexible in the sense that you can provide it the exact configuration it should use. This configuration can be obtained, for example, through the OpenID connect discovery mechanism.
Although there are no tests in this PR, I've tested it in another project against both Google and Microsoft.