Fix sign for OK: decode is not needed and break sign for special cases #998
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an unknown reasons, OK signature was using URL decode while the actual value is already decoded. It leads to the situation when value indeed contains special symbols that can be decoded - signature becomes broken.
PR fixes this and add few sub test cases to validate that.
P.S. Code was not re-indented after
try
deletion: just to re-highlight actual change.