feat: Remove ToastInjector use Injector.create #947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…njector.create This commit removes a custom ToastInjector (that provided a single token) in favor of creating a new injector instance using the `Injector.create` call. The goal of this change is to make the library forward-compatible with an upcoming change to the Injector interface, see angular/angular#46761.
Since the Toastinjector was removed in the previous commit, the file name becomes inaccurate. This commit renames the toast-injector.ts to toast-ref.ts to better reflect the content of the file.
Codecov ReportBase: 55.57% // Head: 55.42% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #947 +/- ##
==========================================
- Coverage 55.57% 55.42% -0.16%
==========================================
Files 19 19
Lines 511 507 -4
Branches 88 87 -1
==========================================
- Hits 284 281 -3
Misses 216 216
+ Partials 11 10 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
scttcper
changed the title
scttcper
changed the title
|
🎉 This PR is included in version 15.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
@scttcper thank you! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR the custom ToastInjector (that provides a single token) is removed in favor of creating a new injector instance using the
Injector.createcall.The goal of this change is to make the library forward-compatible with an upcoming change to the Injector interface, see angular/angular#46761.