Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Remove ToastInjector use Injector.create #947

Merged
merged 2 commits into from Sep 28, 2022
Merged

feat: Remove ToastInjector use Injector.create #947

merged 2 commits into from Sep 28, 2022

Commits on Sep 26, 2022

  1. refactor: remove ToastInjector in favor of creating an instance via I… 

    …njector.create

This commit removes a custom ToastInjector (that provided a single token) in favor of creating a new injector instance using the `Injector.create` call.

The goal of this change is to make the library forward-compatible with an upcoming change to the Injector interface, see angular/angular#46761.
    @AndrewKushnir
    AndrewKushnir committed Sep 26, 2022
    Copy the full SHA
    9d16233 View commit details
    Browse the repository at this point in the history

  2. refactor: rename toast-injector.ts -> toast-ref.ts 

    Since the Toastinjector was removed in the previous commit, the file name becomes inaccurate. This commit renames the toast-injector.ts to toast-ref.ts to better reflect the content of the file.
    @AndrewKushnir
    AndrewKushnir committed Sep 26, 2022
    Copy the full SHA
    d17fce1 View commit details
    Browse the repository at this point in the history