feat: move toast css display outside of animation #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 This PR is included in version 9.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
| ), | ||
| state('active', style({})), | ||
| state('inactive', style({ opacity: 0 })), | ||
| state('active', style({ opacity: 1 })), |
There was a problem hiding this comment.
Guess it doesn't completely fix it. It's fixed when using the ToastComponent, but when using the ToastNoAnimation component the issue still exists.
There was a problem hiding this comment.
I think to fix it for ToastNoAnimation we'd want to apply something similar here:
ngx-toastr/src/lib/toastr/toast-noanimation.component.ts
Lines 56 to 62 in 720af1a
Instead of binding to "style.display" we could bind to just "style" and return both the display and opacity?
There was a problem hiding this comment.
i don't know if you can return an object there
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seems to be caused by angular/angular#28911
closes #630