Added a couple of new options #898
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scttcper
reviewed
Aug 26, 2021
src/lib/toastr/toast.component.ts
Outdated
| @@ -47,7 +50,7 @@ import { ToastrService } from './toastr.service'; | |||
| ), | |||
| transition( | |||
| 'active => removed', | |||
| animate('{{ easeTime }}ms {{ easing }}') | |||
| animate('{{ hideEasingTime }}ms {{ hideEasing }}') | |||
There was a problem hiding this comment.
i think this is a breaking change since anyone that has set the easeTime would now get the default
There was a problem hiding this comment.
should keep the names similar hideEaseTime
1. HTML for the close button 2. Options for selecting the type of ease (one for showing and one for hiding) 3. Options to configure the ease time (in and out) The new hideEaseTime property is only used if it's defined, otherwise a fallback to easeTime is done so that there is no breaking change.
fbandrei
force-pushed
the
new-options
branch
from
cd3fc87
to
91e5555
Compare
|
I fixed that breaking change by adding a fallback to the easeTime property if the new hideEaseTime property is not defined. Thus, there is no breaking change any more. |
|
can this pull request be integrated? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a couple of new options
hiding)
I added these options in the demo example as well, please check them out.
Feel free to change the namings as you wish.