Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update success, info, and warning colors. #943

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codergeek42
Copy link

Updates the success, info, and warning colors to be WCAG AA-compliant (contrast ratio of at least 4.5:1 from background color to white body text).

Updates the success, info, and warning colors to be WCAG AA-compliant (contrast ratio of at least 4.5:1 from background color to white body text).
@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #943 (4aeeef4) into master (8a0a9bf) will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #943      +/-   ##
==========================================
+ Coverage   55.57%   55.77%   +0.19%     
==========================================
  Files          19       19              
  Lines         511      511              
  Branches       88       88              
==========================================
+ Hits          284      285       +1     
  Misses        216      216              
+ Partials       11       10       -1     
Impacted Files Coverage Δ
src/app/home/home.component.ts 58.57% <0.00%> (-1.43%) ⬇️
src/lib/toastr/toastr.service.ts 50.52% <0.00%> (+2.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a0a9bf...4aeeef4. Read the comment docs.

@deltaGPhys
Copy link

The contrast issue is preventing me from using the library - is there any chance that this will be merged?

Copy link

@mymo689 mymo689 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants