Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toastr sound #978

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

csachdeva83
Copy link

* Install howler package
* Add error.mp3 and success.mp3 files
* Add error,info,success,warning.mp3 sounds
* Create toast type and sound map
* Play sound in openToast method
* Enable & Disable Sound option add in home html
* Add enableSound key in interface IndividualConfig
* Default enableSound is false
@codecov
Copy link

codecov bot commented Feb 25, 2023

Codecov Report

Base: 55.11% // Head: 55.49% // Increases project coverage by +0.37% 🎉

Coverage data is based on head (e5325d9) compared to base (efaf809).
Patch coverage: 50.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #978      +/-   ##
==========================================
+ Coverage   55.11%   55.49%   +0.37%     
==========================================
  Files          19       19              
  Lines         508      510       +2     
  Branches       88       89       +1     
==========================================
+ Hits          280      283       +3     
- Misses        216      217       +1     
+ Partials       12       10       -2     
Impacted Files Coverage Δ
src/lib/toastr/toastr-config.ts 94.73% <ø> (ø)
src/app/home/home.component.ts 58.33% <50.00%> (-0.24%) ⬇️
src/lib/toastr/toastr.service.ts 51.04% <0.00%> (+2.08%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@csachdeva83
Copy link
Author

@scttcper Please review this PR and list out any changes you desire.

@scttcper
Copy link
Owner

its interesting, but i don't think it belongs as part of the toastr

@csachdeva83
Copy link
Author

its interesting, but i don't think it belongs as part of the toastr

Why so ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants