Introspect operator image to prevent skew with the sidecar #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scylla-operator-bot
bot
added
the
do-not-merge/work-in-progress
scylla-operator-bot
bot
added
approved
tnozicka
force-pushed
the
resolve-image
branch
6 times, most recently
from
9ffadd4
to
7c2160e
Compare
tnozicka
changed the title
scylla-operator-bot
bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tnozicka, zimnx The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
rzetelskik
reviewed
Sep 29, 2023
There was a problem hiding this comment.
It's a shame we have to pull the Pod's status for that, I though it could be possible with OCI compliant runtimes but it looks like the only way to do it now is hacky and may be unreliable due to pause containers (opencontainers/runtime-spec#1105 and containerd/containerd#8185).
Left two comments.
|
/assign @tnozicka |
tnozicka
force-pushed
the
resolve-image
branch
from
7c2160e
to
24b2d61
Compare
|
/lgtm |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of your changes:
This PR let's the scylla operator image be introspected from pod status when run in the cluster.
Which issue is resolved by this Pull Request:
Resolves #1424