tests: coroutines_test: add reproducers for #1913 #2187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
again even if the previous returned `yield_awaiter` is not ready, and that not-ready awaiter has not been resumed. another problem is that, the awaiter in generator coroutine fails to keep the async buffer alive when caller of async generator either drains the generator or returns without draining the generator. either way, some test cases are added in this test for two purposes: 1. as reproducers, they can be used to verify their fixes 2. these test cases should help to prevent future regressions after the fixes get included. Refs scylladb#1913 Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
again even if the previous returned
yield_awaiteris not ready, and that not-ready awaiter has not been resumed. another problem is that, the awaiter in generator coroutine fails to keep the async buffer alive when caller of async generator either drains the generator or returns without draining the generator. either way, some test cases are added in this test for two purposes:Refs #1913