iotune: allow user to set buffer size for random IO #2204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xemul
reviewed
Apr 25, 2024
pwrobelse
force-pushed
the
iotune-fix-for-incorrect-buffer-size
branch
from
abeaa25
to
97ca725
Compare
pwrobelse
changed the title
xemul
reviewed
Apr 26, 2024
In some cases the buffer size used by iotune was incorrect. Because of that, the reported IOPS for random write was lower than expected. This change adds '--random-io-buffer-size <SIZE>' parameter that enables users to force the buffer size used in measurements of random read and random write IOPS. Refs: scylladb#1698 Signed-off-by: Patryk Wrobel <patryk.wrobel@scylladb.com>
pwrobelse
force-pushed
the
iotune-fix-for-incorrect-buffer-size
branch
from
97ca725
to
b9ff09b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases the buffer size used by iotune was
incorrect. Because of that, the reported IOPS
for random write was lower than expected.
This change adds '--random-io-buffer-size '
parameter that enables users to force the buffer
size used in measurements of random read and
random write IOPS.