http: to_reply() from redirect_exception
#2206
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WillemKauf
force-pushed
the
http_exception_headers_syclla
branch
from
ac23cf0
to
6a41444
Compare
This function allows for the creation of an `http::reply` from a thrown `redirect_exception`, with a url for the `Location` header and an optional `Retry-After` timeout value.
WillemKauf
force-pushed
the
http_exception_headers_syclla
branch
from
6a41444
to
6196a68
Compare
|
@nyh , please review |
nyh
reviewed
May 23, 2024
| redirect_exception(const std::string& url, http::reply::status_type status = http::reply::status_type::moved_permanently) | ||
| : base_exception("", status), url(url) { | ||
| redirect_exception(const std::string& url, http::reply::status_type status = http::reply::status_type::moved_permanently, const std::optional<int>& retry_after = std::nullopt) | ||
| : base_exception("", status), url(url), retry_after(retry_after) { |
There was a problem hiding this comment.
You should mention in the commit message (and perhaps even split the commit into two) that one of the things that this patch does is to add to add Retry-After header (see https://datatracker.ietf.org/doc/html/rfc7231#section-7.1.3) support for redirections.
It is separate feature from the to_reply() function you are adding in this patch.
| @@ -94,6 +93,9 @@ future<std::unique_ptr<http::reply> > routes::handle(const sstring& path, std::u | |||
| handler->verify_mandatory_params(*req); | |||
| auto r = handler->handle(path, std::move(req), std::move(rep)); | |||
| return r.handle_exception(_general_handler); | |||
| } catch (const redirect_exception& _e) { | |||
| *rep = _e.to_reply(); | |||
| rep->done("json"); | |||
There was a problem hiding this comment.
This catch was missing previously. It looks like it fixes a bug - can you explain in the commit message what bug this was? Can you perhaps write a unit test for it?
|
The commit message made it sound like your patch only added a new API function, but as I noted in the review above, it actually included two more separate changes:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
redirect_exception::to_reply()for construction of ahttp::replyfrom a redirect case, with aLocationheader and optionally aRetry-Afterheader.