Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: coroutine/async_generator: reimplement async generator #2218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

RFC: coroutine/async_generator: reimplement async generator #2218

wants to merge 1 commit into from

Conversation

tchaikov
Copy link
Contributor

@tchaikov tchaikov commented May 3, 2024 •
edited

this generator implementation is inspired by https://wg21.link/P2502R2. it does not address the ping-pong problem. if this change is reviewed and is acceptable, i will

  • replace the existing seastar::coroutine::experimental with this implementation
  • drop the generator tests in coroutines_test.cc. and keep generator_test.cc which is dedicated to generator.
  • try to improve it in an iterative manner -- add the buffered variant after this one lands.

@tchaikov
coroutine/async_generator: reimplement async generator
b4d799c 
this generator implementation is inspired by https://wg21.link/P2502R2.

Refs scylladb#2190
Refs scylladb#1913
Refs scylladb#1677
Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
@xemul xemul requested a review from avikivity May 7, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avikivity avikivity Awaiting requested review from avikivity

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@tchaikov