reactor: print scheduling group along with backtrace #2221
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nvartolomei
force-pushed
the
nv/backtrace-with-sched-group
branch
from
576426a
to
86dbc42
Compare
xemul
reviewed
May 7, 2024
nvartolomei
force-pushed
the
nv/backtrace-with-sched-group
branch
from
86dbc42
to
56b17cc
Compare
Backtraces are printed in at least 2 cases: 1) during segfaults, 2) during reactor stalls. Extra context is always helpful in identifying the exact circumstances during which the above happen. E.g. in a server application where user requests are processed in one (or more) scheduling group(s), background processes are split between different scheduling groups as well, knowing the scheduling group narrows the search space. Prior to this commit: ``` Segmentation fault on shard 0. Backtrace: ... ``` With this commit: ``` Segmentation fault on shard 0, in scheduling group main. Backtrace: ... ``` Ref scylladb#2216
nvartolomei
force-pushed
the
nv/backtrace-with-sched-group
branch
from
56b17cc
to
2ae0df3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reactor: print scheduling group along with backtrace
Backtraces are printed in at least 2 cases:
Extra context is always helpful in identifying the exact circumstances
during which the above happen. E.g. in a server application where user
requests are processed in one (or more) scheduling group(s), background
processes are split between different scheduling groups as well, knowing
the scheduling group narrows the search space.
Prior to this commit:
With this commit:
Ref #2216