httpd: mark http_server_control::stop() noexcept #2236
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the only callee in `http_server_control::stop()` is `sharded<Service>::stop()`, which is `noexcept`. so we can assume that `http_server_control::stop()` is also `noexcept`. so, in this change, we mark `http_server_control::stop()` noexcept. this allows us to use `deferred_stop` to stop an `http_server_control`. Signed-off-by: Kefu Chai <kefu.chai@scylladb.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the only callee in
http_server_control::stop()issharded<Service>::stop(), which isnoexcept. so we can assume thathttp_server_control::stop()is alsonoexcept.so, in this change, we mark
http_server_control::stop()noexcept. this allows us to usedeferred_stopto stop anhttp_server_control.