Remove rosetta2 hack for arm64 on Mac #1205
Open
+2
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marc0der
force-pushed
the
remove-rosetta2-hack
branch
from
3795e02
to
32381dc
Compare
marc0der
force-pushed
the
remove-rosetta2-hack
branch
from
32381dc
to
a05ad67
Compare
eddumelendez
approved these changes
May 15, 2023
Hi, maybe it’s too early to remove this option? There are still plenty of java native x86 libraries which does not have an arm port. There is also jdk bugs (e.g. Unsafe#getLongVolatile) in arm where it’s nice to be able to switch over to x86. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduced this hack when there were very few JDKs available for the ARM64 variant of Mac.
Subsequently, many versions of Java have become available for ARM64 Mac, making this hack redundant. This PR removes all support for this functionality.