Fix linking in windows bash environment #529
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In windows the link command simply creates a copy of the directory and hence the removal of the directory fails without the `-r` flag
marc0der
reviewed
Jan 24, 2017
| @@ -82,7 +82,7 @@ function __sdkman_link_candidate_version { | |||
|
|
|||
| # Change the 'current' symlink for the candidate, hence affecting all shells. | |||
| if [[ -h "${SDKMAN_CANDIDATES_DIR}/${candidate}/current" || -d "${SDKMAN_CANDIDATES_DIR}/${candidate}/current" ]]; then | |||
| rm -f "${SDKMAN_CANDIDATES_DIR}/${candidate}/current" | |||
| rm -fr "${SDKMAN_CANDIDATES_DIR}/${candidate}/current" | |||
There was a problem hiding this comment.
I would consider a recursive forced removal to be dangerous.
There was a problem hiding this comment.
This is on windows using git-bash
marc0der
force-pushed
the
master
branch
4 times, most recently
from
23b054e
to
7ee2c51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In windows the link command simply creates a copy of the directory and hence the removal of the directory fails without the
-rflag