Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the vendor of dragonwell #16

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Accelerator1996
Copy link

No description provided.

@Accelerator1996
Copy link
Author

@eddumelendez Please review the PR, thank you very much!

@eddumelendez
Copy link
Member

eddumelendez commented Nov 15, 2023

Hi, this should match the one in sdkman. I haven't seen any in sdkman about it. Can you point me to that change?

@Accelerator1996
Copy link
Author

Hi, this should match the one in sdkman. I haven't seen any in sdkman about it. Can you point me to that change?

Hi, our company's name is Alibaba, and our jdk is called Alibaba Dragonwell. The original albba is not clear enough, so I want to update the vendor.

@eddumelendez
Copy link
Member

the rename doesn't happen in this repo. As I asked already, can you point me to the PR doing the rename?

@Accelerator1996
Copy link
Author

the rename doesn't happen in this repo. As I asked already, can you point me to the PR doing the rename?

Sorry, please tell me which repo should I make changes in?

@tonycody
Copy link

tonycody commented Dec 6, 2023

the rename doesn't happen in this repo. As I asked already, can you point me to the PR doing the rename?

Sorry, please tell me which repo should I make changes in?

@Accelerator1996 理论上这个直接合并就行了,因为 Dragonwell 在 Foojay Disco 里面没有变化。

https://github.com/sdkman/sdkman-candidates
https://github.com/sdkman/sdkman-website

里面都得变更,否则映射不上!

@eddumelendez He's just trying to change the vendor mapping. The albba names didn't make sense in the past.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants