-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(wasm): add support for wasip2, aka webassembly components, using wasi-http
#2290
base: master
Are you sure you want to change the base?
feat(wasm): add support for wasip2, aka webassembly components, using wasi-http
#2290
Conversation
Thanks for taking a look at this! I think support WASI is likely a good goal, in general. However, I usually try to have the discussion in an issue first. I find it's helpful to find consensus before spending too much time going down a certain implementation path, or even working on a feature that won't be accepted at all. So while I do appreciate exploring the area, and exploration is often needed to inform more complex features, I do want to set proper expectations: we might not do this, or do it very differently. 馃檲 |
@seanmonstar that's why I opened the draft PR! Glad I ended up doing that before I got too far down the road. I can open up an issue then and point at this branch as a reference if that's what you prefer |
9d87534
to
2811301
Compare
Created #2294 to further the discussion, @seanmonstar please feel free to either close this PR for now while we continue in the issue or leave it open, totally up to the way you like to track the OSS work. |
7a17bbe
to
f623025
Compare
Rebased this PR off of |
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> refactor(wasm): add wasm mod Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com> wip: feat(wasm): add component feature Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
f623025
to
b083bbd
Compare
Fixes #2294
Hey there! This is a work-in-progress PR that adds support for using reqwest with wasi-http. It was really neat to see the support for wasm_bindgen and JavaScript bindings for requests, and this PR helps support the component model in addition to wasm_bindgen.
I wanted to open this PR to see if you had any suggestions, requests from the initial working code/refactor perspective, and if there's any additional material you'd like me to clarify. If this fits within your general contribution guidelines, I'll wrap it up and mark as ready for review!
This code is still very littered with unwraps and comments, so go easy on me if you take a look at the implementation 馃槄 . To name a few, here's the things I want to do still for this PR:
dox
, kill unwraps, expects, and panicswit-bindgen
behind the wasm32 family of depsLast but not least, thanks for this library! Love
reqwest
鉂わ笍