Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependency upgrade #27

Merged
merged 7 commits into from Apr 29, 2021
Merged

Dependency upgrade #27

merged 7 commits into from Apr 29, 2021

Conversation

twelch
Copy link
Contributor

@twelch twelch commented Feb 23, 2021

Will let this slow burn for up to a week or two if needed.

Notable

  • Typescript 4.1.5
  • Lerna 4.0
  • React 16
  • Turf 6.3.0
    • Turf modules all brought up to matching 6.3.0, they were out of sync which seems problematic if they rely on one another, could produce inconsistencies. Not clear if any versions held back previously for any particular reason but it's been mentioned by @underbluewaters.
  • Node types upgraded to 14.x to match new support for Node 14+
  • wasn't obvious that @shelf/jest-dynamodb was being used, but tasks.test.ts does via jest config preset
  • @types are matched to their counterpart library major/minor version or approximate release date when possible to not be out of sync/ahead.

Removed

  • jest-dynalite, appeared unused
  • styled-components-table, appeared unused

Held back

  • ts-loader - webpack 5 hold
  • val-loader - webpack 5 hold
  • webpack - webpack 5 hold
  • webpack-bundle-analyzer - webpack 5 hold
  • webpack-cli - webpack 5 hold
  • html-webpack-plugin - webpack 5 hold
  • React: upgraded only to 16.x, 17.x wasn't well supported across libs including react-table, storybook, etc.
  • Inquirer: left on 7.x because inquirer-autocomplete-prompt doesn't support peerDependency of 8.x

@twelch twelch added this to In progress in Kanban Board Feb 24, 2021
@twelch twelch self-assigned this Feb 24, 2021
@twelch twelch changed the base branch from master to dev April 27, 2021 15:58
@twelch twelch marked this pull request as ready for review April 27, 2021 17:29
@twelch twelch changed the title WIP: Dep upgrade Dependency upgrade Apr 27, 2021
@twelch twelch merged commit 6643ba2 into dev Apr 29, 2021
@twelch twelch deleted the dep-upgrade branch April 29, 2021 18:59
twelch added a commit that referenced this pull request May 12, 2021
* big bumps

* 🐛 read-pkg-up api change fix

* 🐛 slonik type fixes

* 🐛 slonik type fixes

* 🐛 fix double webpack-dev-server dep

* bump turf deps in templates

* few remaining bumps, rebuild lockfiles
@twelch twelch mentioned this pull request May 14, 2021
@twelch
Copy link
Contributor Author

twelch commented Feb 3, 2022

Be on the lookout, in attempting to update just react deps and react-table, the client project builds would then error in building the client with the following.

Building client...

 2 assets

ERROR in ./src/components/ReportError.tsx 31:8
Module parse failed: Unexpected token (31:8)
File was processed with these loaders:
 * ../../babel-loader/lib/index.js
You may need an additional loader to handle the result of these loaders.
| 
| export class ReportError extends React.Component {
>   state = {
|     hasError: false,
|     error: {

The gp package-lock change a lot in bumping those, so it's possible something funny is going on, perhaps balking on typescript or jsx. Doing a larger rebuild of the lockfile and upgrading more deps to latest may be fruitful but more time is needed.

@twelch
Copy link
Contributor Author

twelch commented Feb 3, 2022

Rolling back gp deps and lockfile didn't resolve. had to roll back the bermuda project lockfile, which had been significantly changed in its bumping of dependencies.

It looks like the verison of babel-loader that was installing was 8.2.3 instead of 8.2.2 as noted in gp paackage.json due to ^ fuzzy matching. So locking to this version and dropping fuzz may get us by.

Possible issue also here and deduping the lockfile may help - webpack/webpack#8656. as noted creating fresh lockfile in gp and client, deduping with acorn, may be the solution.

also locking down the versions and removing fuzzy may help once it is stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Kanban Board
In progress
Development

Successfully merging this pull request may close these issues.

None yet

1 participant