Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification: add Go CDK pubsub support #895

Merged
merged 2 commits into from
Mar 20, 2019
Merged

Conversation

jba
Copy link
Contributor

@jba jba commented Mar 20, 2019

Add the gocdk_pub_sub package, which supports the Go Cloud Development
Kit pubsub API.

Link in all current providers.

Update the notification scaffold.

Add the gocdk_pub_sub package, which supports the Go Cloud Development
Kit pubsub API.

Link in all current providers.

Update the notification scaffold.
@chrislusf
Copy link
Collaborator

Nice! There are some build errors:

'''
121.52s$ go get ./weed/...
package gocloud.dev/pubsub/awssnssqs: unrecognized import path "gocloud.dev/pubsub/awssnssqs" (parse https://gocloud.dev/pubsub/awssnssqs?go-get=1: no go-import meta tags ())
package gocloud.dev/pubsub/azuresb: unrecognized import path "gocloud.dev/pubsub/azuresb" (parse https://gocloud.dev/pubsub/azuresb?go-get=1: no go-import meta tags ())
package gocloud.dev/pubsub/natspubsub: unrecognized import path "gocloud.dev/pubsub/natspubsub" (parse https://gocloud.dev/pubsub/natspubsub?go-get=1: no go-import meta tags ())
The command "go get ./weed/..." failed and exited with 1 during .
Your build has been stopped.
'''

@chrislusf
Copy link
Collaborator

@chrislusf
Copy link
Collaborator

chrislusf commented Mar 20, 2019

Can this gocloud.dev/pubsub be moved/cloned to github?

Seems this is not new: googleapis/google-cloud-go#820 happened more than one year ago.

@jba
Copy link
Contributor Author

jba commented Mar 20, 2019

I'm working on this; it is a problem with go-import redirects for the gocloud.dev import paths.

@jba
Copy link
Contributor Author

jba commented Mar 20, 2019

Tests are passing now.

@chrislusf
Copy link
Collaborator

Thanks a lot!

Is there any way to avoid this in the future? These go import redirects seem fragile.

@chrislusf chrislusf merged commit 287ac1c into seaweedfs:master Mar 20, 2019
@jba
Copy link
Contributor Author

jba commented Mar 20, 2019

Is there any way to avoid this in the future? These go import redirects seem fragile.

We're automating our process so this won't happen again.

More generally, the Go ecosystem will soon have proxies, which will pretty much end availability issues. Run go help goproxy in Go 1.12.

@jba jba deleted the gocdk branch March 20, 2019 21:25
@chrislusf
Copy link
Collaborator

@jba SeaweedFS use the notification to replicate files across systems. The current PR implemented SendMessage(). We need another one to ReceiveMessage(), similar to https://github.com/chrislusf/seaweedfs/blob/master/weed/replication/sub/notification_google_pub_sub.go#L94

Could you please also help here? Thanks!

@jba
Copy link
Contributor Author

jba commented Mar 31, 2019

Sure, I'll try to get to it this week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants