Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix JSON object order comparision with numeric keys #4675

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Fix JSON object order comparision with numeric keys #4675

wants to merge 10 commits into from

Commits on May 19, 2021

  1. Initial tests, including failing

    @Firehed
    Firehed committed May 19, 2021
    Configuration menu
    Copy the full SHA
    29e1e9c View commit details
    Browse the repository at this point in the history

  2. Change sort during canonicalization

    @Firehed
    Firehed committed May 19, 2021
    Configuration menu
    Copy the full SHA
    824b634 View commit details
    Browse the repository at this point in the history

  3. More tests

    @Firehed
    Firehed committed May 19, 2021
    Configuration menu
    Copy the full SHA
    6701598 View commit details
    Browse the repository at this point in the history

  4. Rework internals to cover other cases

    @Firehed
    Firehed committed May 19, 2021
    Configuration menu
    Copy the full SHA
    d20d4a8 View commit details
    Browse the repository at this point in the history

  5. Match existing alignment:

    @Firehed
    Firehed committed May 19, 2021
    Configuration menu
    Copy the full SHA
    fe44e4b View commit details
    Browse the repository at this point in the history

  6. More alignment

    @Firehed
    Firehed committed May 19, 2021
    Configuration menu
    Copy the full SHA
    dc3bf4c View commit details
    Browse the repository at this point in the history

Commits on May 20, 2021

  1. Attempt to fix Psalm complaint

    @Firehed
    Firehed committed May 20, 2021
    Configuration menu
    Copy the full SHA
    ad2db46 View commit details
    Browse the repository at this point in the history

  2. stdclass now unused

    @Firehed
    Firehed committed May 20, 2021
    Configuration menu
    Copy the full SHA
    313d58e View commit details
    Browse the repository at this point in the history

  3. Add blank line between statements

    @Firehed
    Firehed committed May 20, 2021
    Configuration menu
    Copy the full SHA
    0e6be9b View commit details
    Browse the repository at this point in the history

  4. Apply remaining phpcs rules

    @Firehed
    Firehed committed May 20, 2021
    Configuration menu
    Copy the full SHA
    aec46c1 View commit details
    Browse the repository at this point in the history