Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Extract IncludeNameFilter #5722

Closed
wants to merge 1 commit into from

Conversation

localheinz
Copy link
Collaborator

This pull request

  • extracts an IncludeNameFilter

Follows 697b867.

@localheinz localheinz force-pushed the feature/filter branch 2 times, most recently from b2bce1f to 7acd6f0 Compare March 8, 2024 13:18
Copy link

codecov bot commented Mar 8, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 89.95%. Comparing base (d1c9957) to head (19b107b).
Report is 6 commits behind head on 11.0.

❗ Current head 19b107b differs from pull request most recent head b944719. Consider uploading reports for the commit b944719 to get more accurate results

Files Patch % Lines
src/Runner/Filter/ExcludeNameFilterIterator.php 80.00% 2 Missing ⚠️
src/Runner/Filter/IncludeNameFilterIterator.php 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               11.0    #5722   +/-   ##
=========================================
  Coverage     89.95%   89.95%           
- Complexity     6460     6468    +8     
=========================================
  Files           683      683           
  Lines         19586    19599   +13     
=========================================
+ Hits          17619    17631   +12     
- Misses         1967     1968    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

@sebastianbergmann sebastianbergmann added type/refactoring A refactoring that should be applied to make the code easier to understand and maintain feature/test-runner CLI test runner event/code-sprint/2024-03 PHPUnit Code Sprint: March 2024 labels Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
event/code-sprint/2024-03 PHPUnit Code Sprint: March 2024 feature/test-runner CLI test runner type/refactoring A refactoring that should be applied to make the code easier to understand and maintain
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants