Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro-optimize TestRunner::runTestWithTimeout() #5740

Closed
wants to merge 1 commit into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 12, 2024

the function call is showing up in blackfire profiles of blackfire run php ./phpunit --testsuite unit

grafik

@sebastianbergmann sebastianbergmann added type/performance Issues related to resource consumption (time and memory) version/10 Something affects PHPUnit 10 version/11 Something affects PHPUnit 11 labels Mar 12, 2024
@sebastianbergmann
Copy link
Owner

Cherry-picked into 10.5 and merged to 11.0 and main from there. Thanks!

@staabm
Copy link
Contributor Author

staabm commented Mar 12, 2024

should I target future performance PRs directly to 10.5 ?

@staabm staabm deleted the size branch March 12, 2024 07:27
@sebastianbergmann
Copy link
Owner

If they also apply to 10.5 then yes, please. Thanks!

@sebastianbergmann sebastianbergmann added the feature/test-runner CLI test runner label Mar 12, 2024
@sebastianbergmann sebastianbergmann changed the title Micro optimize TestRunner->runTestWithTimeout() Micro-optimize TestRunner::runTestWithTimeout() Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/test-runner CLI test runner type/performance Issues related to resource consumption (time and memory) version/10 Something affects PHPUnit 10 version/11 Something affects PHPUnit 11
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants