Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "fsockopen(): Unable to connect to hostname:0" warning #5783

Merged
merged 1 commit into from
Mar 31, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Mar 31, 2024

another try at fixing #5779 (comment)

after looking a bit into it, it seems that phpunit will only fail a test when a warning is triggered from the test itself, but not the dataprovider.. intentional?

Copy link

codecov bot commented Mar 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.18%. Comparing base (484cacc) to head (7900ad8).

Additional details and impacted files
@@            Coverage Diff            @@
##               10.5    #5783   +/-   ##
=========================================
  Coverage     90.18%   90.18%           
  Complexity     6434     6434           
=========================================
  Files           679      679           
  Lines         19531    19531           
=========================================
  Hits          17614    17614           
  Misses         1917     1917           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sebastianbergmann
Copy link
Owner

it seems that phpunit will only fail a test when a warning is triggered from the test itself

This is similar to #5775.

@sebastianbergmann sebastianbergmann merged commit f908345 into sebastianbergmann:10.5 Mar 31, 2024
31 checks passed
@staabm staabm deleted the fix-warn branch March 31, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants