Add import attributes feature #381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adams85
force-pushed
the
feature/import-attributes
branch
from
2f4a1a0
to
bc9a220
Compare
This was referenced Apr 9, 2023
Closed
This reverts commit 695825c.
…hanges ("Attributes" properties instead of "Assertions")
adams85
force-pushed
the
feature/import-attributes
branch
from
bc9a220
to
fcd176f
Compare
|
Looks like the proposal is as final as it can get now, so I resolved the merge conflicts and we can merge this as well. Any objections? |
lahma
reviewed
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-adds the experimental Import Attributes feature (formerly known as Import Assertions).
See also:
The proposal seems to be WIP ("reached conditional consensus"), so I suggest we don't merge this for now but wait until they finish this issue or, rather, until they implement it in V8 because of this.