Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse Bluetooth vendor IDs #784

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

schontz
Copy link

@schontz schontz commented Mar 10, 2023

Fixes #783

@schontz
Copy link
Author

schontz commented Mar 10, 2023

This still falls back to device_name for manufacturer. I'd suggest we don't use that as fallback because it could accidentally contain PII. For apps that are trying to remove PII when logging, they do not expect PII to be found in a manufacturer field.

@sebhildebrandt
Copy link
Owner

sebhildebrandt commented Mar 11, 2023

@schontz ... THANK YOU David! I need to have a closer look. As posted yesterday I also started to work on a fix for that. I also need to test the resulting fix on several machines. Will come back as soon as I have finished it.

@schontz
Copy link
Author

schontz commented Mar 13, 2023

Sounds good. I only tested on my machine, so this will obviously need a broader test.

@sebhildebrandt
Copy link
Owner

@schontz SORRY! Still did not had time to test all of it but I hope I get some free time slot beginning of next week.

@schontz
Copy link
Author

schontz commented Jun 28, 2023

No apologies necessary. For what it's worth, I've been running with a patched version of this without any issue, so it at least isn't breaking things.

@sebhildebrandt
Copy link
Owner

@schontz yes, but you spend your time on this nice patch!! I really appreciate it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect manufacturer detected for Bluetooth Apple Magic Keyboard
2 participants