Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Remove close-handler for powershell child process #865

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Bugfix: Remove close-handler for powershell child process #865

wants to merge 1 commit into from

Commits on Apr 12, 2024

  1. Remove close-handler for powershell child process 

    2 problems could arise in the close-event handler if powerShellStart() is called after powerShellRelease():

1. the variable _psChild could be null if the close-event was fired after the null assignment but before the spawn() call returns.
(in my tests when powerShellStart is called 1s after powerShellRelease).

2. the signal from the kill()-call could be delivered to the newly created powershell subprocess.
(in my tests when powerShellStart is called directly after powerShellRelease).

In my view, the close handler is not necessary.
    @evekto
    evekto authored and Alexander Danzer committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    8aa1ebe View commit details
    Browse the repository at this point in the history