Commits on Nov 27, 2023

1. WiFi: Get connection info using UUID instead of SSID …

   If you have multiple WiFi interfaces connecting to "YOUR_SSID", the
   SSID reported back by nmcli might be named "YOUR_SSID <N>", where <N>
   is replaced by a digit. While this is in general no problem, this SSID
   isn't properly "sanitized" (or escaped?) by util.sanitizeShellString()
   which leads to that YOUR_SSID and <N> gets interpreted as separate
   arguments when passed to nmcli (nmiConnectionLinux()), which in turn
   makes the information for "YOUR_SSID" to be wrongfully returned.
   
   To avoid the problem of properly escaping the string, just use the
   UUID for the connection instead for fetching the information, since
   that should never contain any harmful characters.
   
   (The argument escape problem can probably be solved also by using
   spawn/spawnSync(), where arguments can be sent as a list instead, and
   which also returns stdio and stderr as separate objects. Anyhow,
   perhaps something for the long awaited version 6.)

   

   sylt committed Nov 27, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for c1bc967
   • Browse repository at this point

   Copy the full SHA

   c1bc967 View commit details

   Browse the repository at this point in the history