Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix SOMEIP answers function, in case there is SD above #4061

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

geynis
Copy link

@geynis geynis commented Jul 10, 2023

Checklist:

  • [V] If you are new to Scapy: I have checked CONTRIBUTING.md (esp. section submitting-pull-requests)
  • [V] I squashed commits belonging together
  • [] I added unit tests or explained why they are not relevant
  • I executed the regression tests (using cd test && ./run_tests or tox)
  • If the PR is still not finished, please create a Draft Pull Request

This fixes a bug in the answers function of SOMEIP, in case there is a SD above it. it should be considered.

fixes #xxx

@polybassa
Copy link
Contributor

Thanks for your PR. Could you please add a unit test for this case?

@codecov
Copy link

codecov bot commented Jul 10, 2023

Codecov Report

Merging #4061 (54c5599) into master (6dbdc37) will decrease coverage by 0.01%.
Report is 199 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4061      +/-   ##
==========================================
- Coverage   81.95%   81.94%   -0.01%     
==========================================
  Files         327      327              
  Lines       75540    75542       +2     
==========================================
- Hits        61911    61906       -5     
- Misses      13629    13636       +7     
Files Coverage Δ
scapy/contrib/automotive/someip.py 92.92% <0.00%> (-0.83%) ⬇️

... and 4 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants