Add some commands in Chapter 7.4 #4107
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4107 +/- ##
==========================================
+ Coverage 81.59% 81.97% +0.38%
==========================================
Files 328 328
Lines 75949 75958 +9
==========================================
+ Hits 61968 62264 +296
+ Misses 13981 13694 -287
|
|
Thanks for the PR ! Could you add one (or more) unit tests? Thanks |
|
Should this PR include some layer binding? |
| 7.4.1 Read Local Version Information command | ||
|
|
||
| """ | ||
| name = "HCI_Read_Local_Version_Information" |
There was a problem hiding this comment.
This packets don't have a field_desc. Why are they useful for you?
There was a problem hiding this comment.
Because they set an opcode or ogf and ocf in the parent packet.
They are part of the Bluetooth specification and have a function.
| @@ -1038,9 +1038,52 @@ class HCI_Cmd_Write_LE_Host_Support(Packet): | |||
|
|
|||
|
|
|||
| # 7.4 INFORMATIONAL PARAMETERS, the OGF is defined as 0x04 | |||
| class HCI_Cmd_Read_Local_Version_Information(Packet): | |||
| """ | |||
|
|
|||
There was a problem hiding this comment.
In previous PRs the class docstring was added but without newlines. Should the empty lines be removed?
| @@ -1038,9 +1038,52 @@ class HCI_Cmd_Write_LE_Host_Support(Packet): | |||
|
|
|||
|
|
|||
| # 7.4 INFORMATIONAL PARAMETERS, the OGF is defined as 0x04 | |||
| class HCI_Cmd_Read_Local_Version_Information(Packet): | |||
There was a problem hiding this comment.
This packet is missing the corresponding binding.
| name = "HCI_Read_Local_Version_Information" | ||
|
|
||
|
|
||
| class HCI_Cmd_Read_Local_Supported_Commands(Packet): |
There was a problem hiding this comment.
This packet is missing the corresponding binding.
| name = "HCI_Read_Local_Supported_Commands" | ||
|
|
||
|
|
||
| class HCI_Cmd_Read_Local_Supported_Features(Packet): |
There was a problem hiding this comment.
This packet is missing the corresponding binding.
| name = "HCI_Read_Local_Supported_Features" | ||
|
|
||
|
|
||
| class HCI_Cmd_Read_Local_Extended_Features(Packet): |
There was a problem hiding this comment.
This packet is missing the corresponding binding.
Checklist:
cd test && ./run_testsortox)fixes #xxx