refactor!: Convert all rules to ESM #535
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
20 tasks
azu
commented
Jul 2, 2023
Comment on lines
+47
to
+50
| }), resolve({ preferBuiltins: false }), commonjs({ | ||
| // disable __esModule interop | ||
| // Node.js ESM does not recognize `__esModule` flag interop | ||
| defaultIsModuleExports: true |
There was a problem hiding this comment.
It is incomatible issue between Node.js ESM and Rollup.
azu
commented
Jul 2, 2023
Comment on lines
+168
to
+181
| const newError = | ||
| error instanceof Error | ||
| ? new Error( | ||
| `Failed to load rule module: ${configDescriptorRule.id} | ||
|
|
||
| Error: ${error.message}`, | ||
| { | ||
| cause: error, | ||
| } | ||
| ) | ||
| : new Error(`Failed to load rule module: ${configDescriptorRule.id} | ||
|
|
||
| Error: ${String(error)}`); | ||
| errors.push(newError); |
azu
changed the title
azu
commented
Jul 2, 2023
| @@ -4,13 +4,21 @@ import commonjs from "@rollup/plugin-commonjs"; | |||
|
|
|||
| export default { | |||
| input: "src/index.ts", | |||
| // gcp rule is broken by moduleSideEffects option | |||
| // treeshake: "smallest", | |||
There was a problem hiding this comment.
treeshake: {
/**
* "smallest" will choose option values for you to minimize output size as much as possible. This should work for most code bases as long as you do not rely on certain patterns, which are currently:
*
* getters with side effects will only be retained if the return value is used (treeshake.propertyReadSideEffects: false)
* code from imported modules will only be retained if at least one exported value is used (treeshake.moduleSideEffects: false)
* you should not bundle polyfills that rely on detecting broken builtins (treeshake.tryCatchDeoptimization: false)
* some semantic issues may be swallowed (treeshake.unknownGlobalSideEffects: false, treeshake.correctVarValueBeforeDeclaration: false)
*/
propertyReadSideEffects: false,
tryCatchDeoptimization: false,
unknownGlobalSideEffects: false,
correctVarValueBeforeDeclaration: false,
moduleSideEffects: (id, external) => {
// node-fetch does not work
if (id.includes("node_modules/node-forge")) {
return true;
}
return false;
}
}
works, but file size is large.
node-forge is big.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Internal
Note
__esModuleflag by default__esModule.commonjs({ defaultIsModuleExports: true })to rollup.