Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure some version information is set when no version was injected into the binary #491

Merged
merged 1 commit into from
Jun 25, 2020

Conversation

ccojocar
Copy link
Member

fixed #323

…d into the binary

Signed-off-by: Cosmin Cojocar <cosmin.cojocar@gmx.ch>
@ccojocar ccojocar requested a review from gcmurphy June 19, 2020 08:31
@codecov-commenter
Copy link

Codecov Report

Merging #491 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #491   +/-   ##
=======================================
  Coverage   71.75%   71.75%           
=======================================
  Files           9        9           
  Lines         662      662           
=======================================
  Hits          475      475           
  Misses        164      164           
  Partials       23       23           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d2c951...15b0956. Read the comment docs.

Copy link
Member

@gcmurphy gcmurphy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome! Thanks!

@ccojocar ccojocar merged commit ad1cb7e into securego:master Jun 25, 2020
@ccojocar ccojocar deleted the version-info-get branch May 13, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Version output is "empty"
3 participants