This repository has been archived by the owner on Jan 10, 2024. It is now read-only.
Add configuration file support and exclude option #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MVrachev
added
work-in-progress
joshuagl
reviewed
Apr 30, 2019
ericwb
reviewed
Apr 30, 2019
MVrachev
removed
the
work-in-progress
|
Trying to prompt Travis with a close/reopen |
|
Go Travis, go! |
joshuagl
reviewed
May 3, 2019
joshuagl
reviewed
May 3, 2019
joshuagl
reviewed
May 3, 2019
ericwb
reviewed
May 15, 2019
joshuagl
previously approved these changes
May 20, 2019
| * @return {Promise<any>} GitHub response | ||
| * See https://developer.github.com/v3/repos/contents/#get-contents | ||
| */ | ||
| async function getConfigFile (context) { | ||
| async function getConfigFile (context, customConfigPath = config.configFilePath) { |
There was a problem hiding this comment.
It's strange that we introduce a new function in commit one of this PR then immediately change it in commit two of the same PR. That's a perfectly natural way for code to evolve during development but not necessary to expose in the revision control history.
There was a problem hiding this comment.
This is a change was introduced when we added our unit tests and that's why I change it in the commit where I added the unit tests.
|
@Browne want to take a last look at this PR before it merges? |
|
My mistake, apologies for the inconvenience @Browne |
|
Giving @ericwb a chance for another look before this merges. |
Our users need a way to configure Precaution for their needs. The first important option to enable will be the "exclude" option. That way the users can exclude their tests folders and files. We decided to give globs as a way for the users to be more flexible when they are creating exclude rules. Because YAML allows you to use comments and it's more human readable than JSON we decided to use .precaution.yaml as a config file. Closes: #179 Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
When we support the configuration file feature we have to execute one more step in our workflow - checking if a Precaution configuration file exists and downloading it from the repository. Also, when we add new config options we should test them if we use them correctly in our workflow. Signed-off-by: Martin Vrachev <mvrachev@vmware.com>
joshuagl
added
the
ready-to-merge
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our users need a way to configure Precaution for their needs.
The first important option to enable will be the "exclude" option.
That way the users can exclude their tests folders and files.
We decided to give globs as a way for the users to be more flexible
when they are creating exclude rules.
Because YAML allows you to use comments and it's more human readable
than JSON we decided to use .precaution.yaml as a config file.
Closes: #179
Signed-off-by: Martin Vrachev mvrachev@vmware.com