Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Spike Serverless plugin thinking #24

Draft
wants to merge 15 commits into
base: main
Choose a base branch
from
Draft

Conversation

72636c
Copy link
Member

@72636c 72636c commented Jan 31, 2024

This is by no means ready to merge, but I'm keen to get feedback on the approach.

The alternative would be for us to run the CDK synth offline and hardcode the CloudFormation resources that we inject rather than relying on CDK to generate them dynamically. This may mean that we'd need to implement our own logic around generating unique CloudFormation resource names (assuming that the current approach exercises CDK name generation in a deterministic fashion 🤔).


E: I'm yet to look at how event source mappings & permissions are updated, so that may end up increasing the effort.

Copy link

changeset-bot bot commented Jan 31, 2024

⚠️ No Changeset found

Latest commit: c493faa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@72636c 72636c changed the title Spike Serverless plugin thinking RFC: Spike Serverless plugin thinking Jan 31, 2024
@72636c 72636c marked this pull request as ready for review January 31, 2024 21:42
@72636c 72636c requested a review from a team as a code owner January 31, 2024 21:42
Base automatically changed from commit-hash to main January 31, 2024 23:13
Copy link
Contributor

@AaronMoat AaronMoat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with some of this, but in the interests of unblocking ✅ in case you don't get any other feedback, as I don't see anything wrong.

The high level approach seems sane.

The installation/setup instructions could probably be replicated to the package's README so that it appears in the NPM package's page.

@72636c 72636c marked this pull request as draft April 22, 2024 23:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants