New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Spike Serverless plugin thinking #24
base: main
Are you sure you want to change the base?
Conversation
|
c0a73b2
to
740e063
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super familiar with some of this, but in the interests of unblocking ✅ in case you don't get any other feedback, as I don't see anything wrong.
The high level approach seems sane.
The installation/setup instructions could probably be replicated to the package's README so that it appears in the NPM package's page.
This is by no means ready to merge, but I'm keen to get feedback on the approach.
The alternative would be for us to run the CDK synth offline and hardcode the CloudFormation resources that we inject rather than relying on CDK to generate them dynamically. This may mean that we'd need to implement our own logic around generating unique CloudFormation resource names (assuming that the current approach exercises CDK name generation in a deterministic fashion 🤔).
E: I'm yet to look at how event source mappings & permissions are updated, so that may end up increasing the effort.