New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
metrics, unpack: Calculate and expose the xWidthAvg
metric
#122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f74ddec The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mrm007
reviewed
Jan 24, 2023
askoufis
reviewed
Jan 24, 2023
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
Co-authored-by: Adam Skoufis <askoufis@users.noreply.github.com>
askoufis
approved these changes
Jan 29, 2023
mrm007
approved these changes
Jan 30, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate the average width of lowercase characters and expose as
xWidthAvg
. This value facilitates calculating better font fall backs, as it enables calculating thesize-adjust
CSS property (see the createFontStack PR).Why a custom metric?
There is a built-in value called
xAvgCharWidth
in the OS/2 table, however the definition of its value has changed over time and is currently the average of all glyphs from a font file. Instead, we calculate an average width of the glyphs based on their frequency of occurrence. From testing this has proved to be quite effective.The
category
fieldThe
category
field exists on every Google Font and describes the font style, e.g. “serif”, ”sans-serif”, etc. We are exposing this (as well as populating it manually for system fonts), as frameworks like NextJS are using it to select which system font to fallback to.Notes
core
with shape of metrics frommetrics
package.metrics
andunpack
from top level readme