Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autofix for custom unsafe-to-chain-command rule #113

Merged
merged 4 commits into from
Jun 6, 2023

Conversation

askoufis
Copy link
Contributor

@askoufis askoufis commented Jun 6, 2023

As the PR title says. Also did a bit of cleanup in the rule comments and docs, and added some JSDoc types to make the rule a bit easier to work with.

The fix was tested in a repo with ~400 errors for this rule, and they were all fixed correctly.

I've updated my upstream PR to include the autofix.

@askoufis askoufis requested a review from a team as a code owner June 6, 2023 03:45
@changeset-bot
Copy link

changeset-bot bot commented Jun 6, 2023

🦋 Changeset detected

Latest commit: 69d814e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-config-seek Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@askoufis askoufis merged commit 39636f0 into master Jun 6, 2023
3 checks passed
@askoufis askoufis deleted the unsafe-to-chain-autofix branch June 6, 2023 04:39
@seek-oss-ci seek-oss-ci mentioned this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants