Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a temporary override for the React import #122

Merged
merged 2 commits into from
Jul 7, 2023
Merged

Conversation

mrm007
Copy link
Contributor

@mrm007 mrm007 commented Jul 7, 2023

No description provided.

@mrm007 mrm007 requested a review from a team as a code owner July 7, 2023 05:27
@changeset-bot
Copy link

changeset-bot bot commented Jul 7, 2023

🦋 Changeset detected

Latest commit: bc19d3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-config-seek Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@@ -36,6 +36,22 @@ const eslintConfig = {
rules: {
...reactRules,
},
overrides: [
{
// temporary override until everybody removes the React import
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could remove this override in the next major. Or just leave it there; it's harmless.

@mrm007 mrm007 merged commit 1efcef3 into master Jul 7, 2023
2 checks passed
@mrm007 mrm007 deleted the react-unused branch July 7, 2023 05:37
@seek-oss-ci seek-oss-ci mentioned this pull request Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants