Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Detect react version in settings #26

Closed
wants to merge 1 commit into from
Closed

Conversation

tgdev
Copy link

@tgdev tgdev commented Nov 5, 2018

Closes issue #25

@tgdev tgdev self-assigned this Nov 5, 2018
@michaeltaranto
Copy link
Contributor

michaeltaranto commented Nov 5, 2018

We might have to hold off on this as the "detect" feature has not been published yet given it was only merged on Oct 17. Not sure what their release cycle is, but the last publish was in August.

@tgdev
Copy link
Author

tgdev commented Nov 5, 2018

'detect' option, although being merged to master in eslint-plugin-react, has not yet being published via npm.

There is also no clear indication on when this might happen so closing this PR for now. Will reopen should the new change be published

@tgdev tgdev closed this Nov 5, 2018
@askoufis askoufis deleted the detect-react-version branch May 24, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants