fix(deps): Update ESLint plugins #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last update in #50 was probably a bit rushed and caught `typescript-eslint@3.0.0`. This release had a lot of really good changes, but also some rough edges due to the new rules lacking real world testing. In particular, typescript-eslint/typescrpit-eslint#2084 made any exported function require all of its inner functions to be fully typed. This is particularly difficult with GraphQL servers as it requires every single resolver function to be fully typed. We effectively halted the rollout of `eslint-config-seek@7.0.0.` waiting for this to be fixed. This has now been included in `typescript-eslint@3.1.0` along with some other hotfixes. It looks like we also hit some near-.0 releases for the other plugins so update those as well even though they've caused no known problems.
72636c
approved these changes
Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last update in #50 was probably a bit rushed and caught
typescript-eslint@3.0.0. This release had a lot of really good changes, but also some rough edges due to the new rules lacking real world testing.In particular, typescript-eslint/typescript-eslint#2084 made any exported function require all of its inner functions to be fully typed. This is particularly difficult with GraphQL servers as it requires every single resolver function to be fully typed. We effectively halted the rollout of
eslint-config-seek@7.0.0.waiting for this to be fixed. This has now been included intypescript-eslint@3.1.0along with some other hotfixes.It looks like we also hit some near-.0 releases for the other plugins so update those as well even though they've caused no known problems.